Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datasets pagination #594

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: datasets pagination #594

merged 2 commits into from
Nov 20, 2024

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Nov 19, 2024

Related ecolabdata/ecospheres#472

  • Corrige le calcul du nombre de pages total (Math.ceil vs Math.round)
  • Utilise un multiple de 10000 (limite ES data.gouv.fr) pour la pagination afin d'éviter une erreur serveur sur la dernière page

On doit maintenant avoir 500 pages de 20, sachant qu'on récupère au max 10k jeux de données via la recherche et que nos univers sont plus grands.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit aa43427
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/673c637d41d28800084c2aa0
😎 Deploy Preview https://deploy-preview-594--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit aa43427
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/673c637d1a27f30008cfb1f1
😎 Deploy Preview https://deploy-preview-594--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte merged commit c81f4bd into main Nov 20, 2024
7 checks passed
@abulte abulte deleted the fix/datasets-pagination branch November 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants